Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IEEE docs #71

Open
tom-bop opened this issue Jul 13, 2017 · 0 comments
Open

Update IEEE docs #71

tom-bop opened this issue Jul 13, 2017 · 0 comments

Comments

@tom-bop
Copy link

tom-bop commented Jul 13, 2017

https://github.com/GaloisInc/cereal/blob/master/src/Data/Serialize/IEEE754.hs#L11 says that you use a method with ST to cast between IEEE types, but that's been reverted: cereal again uses Foreign to cast.

Ideally, instead of removing the comment, you could explain why you switched back? The git history (7cfabb6) makes it clear the decision was made for a good reason:

When serializing/deserializing a lot of nested structures with the intermediate array causes significant GC slowdowns.

...but a newcomer (e.g. me) might wonder why we use something that may be slower than other methods (e.g. http://hackage.haskell.org/package/reinterpret-cast claims to see 5x speedup)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant