You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ideally, instead of removing the comment, you could explain why you switched back? The git history (7cfabb6) makes it clear the decision was made for a good reason:
When serializing/deserializing a lot of nested structures with the intermediate array causes significant GC slowdowns.
https://github.com/GaloisInc/cereal/blob/master/src/Data/Serialize/IEEE754.hs#L11 says that you use a method with
ST
to cast between IEEE types, but that's been reverted: cereal again usesForeign
to cast.Ideally, instead of removing the comment, you could explain why you switched back? The git history (7cfabb6) makes it clear the decision was made for a good reason:
...but a newcomer (e.g. me) might wonder why we use something that may be slower than other methods (e.g. http://hackage.haskell.org/package/reinterpret-cast claims to see 5x speedup)
The text was updated successfully, but these errors were encountered: