Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Shouldn't need ghc and ghc-pkg on path to use halvm-cabal haddock? #104

Open
ntc2 opened this issue Mar 16, 2017 · 3 comments
Open

Shouldn't need ghc and ghc-pkg on path to use halvm-cabal haddock? #104

ntc2 opened this issue Mar 16, 2017 · 3 comments
Labels
Milestone

Comments

@ntc2
Copy link
Contributor

ntc2 commented Mar 16, 2017

Even though Halvm ships its own versions of ghc, ghc-pkg, and haddock, the Halvm-shipped haddock requires a system ghc and ghc-pkg on the path. This seems like a bug.

@dmjio
Copy link
Contributor

dmjio commented Mar 18, 2017

I agree, it does seem like a bug. Now that we have gotten away from the HaLVM platform, I wonder if it would be OK to remove halvm-cabal entirely. If an end-user supplies a cabal, maybe we can instruct them to simply:

cabal configure --with-ghc=$(which halvm-ghc) --with-hc-pkg=$(which halvm-ghc-pkg)

This approach might be too naive.

In regards to haddock, onus could on the user to provide the correct version.

@acw acw added this to the HaLVM 2.5 milestone Mar 24, 2017
@ntc2
Copy link
Contributor Author

ntc2 commented Mar 27, 2017

I think it makes more sense to keep the halvm-* commands around, then require users to learn what they do behind the scenes. Seems much more user friendly. Also, the Halvm docs claim that these prefixed commands are the normal way that cross compilers are used: https://github.com/GaloisInc/HaLVM/wiki/What-is-the-Difference-Between-GHC-and-the-HaLVM?#the-tools.

@dmjio dmjio closed this as completed Mar 27, 2017
@dmjio dmjio reopened this Mar 27, 2017
@dmjio
Copy link
Contributor

dmjio commented Mar 27, 2017

Didn't mean to close. Keeping halvm-cabal sounds good. Only frame of reference is cabal's ghcjs flag, but it seems like they added some code to cabal-install to support this.

cabal install --ghcjs packageName

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants