Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete documentation fo usage with Ignite #504

Open
SlowMo24 opened this issue Apr 19, 2023 · 1 comment · May be fixed by #505
Open

Complete documentation fo usage with Ignite #504

SlowMo24 opened this issue Apr 19, 2023 · 1 comment · May be fixed by #505
Labels
documentation Readmes, Javadoc, Tutorials, etc.

Comments

@SlowMo24
Copy link
Contributor

SlowMo24 commented Apr 19, 2023 •
edited

Problem Description

Since the switch to Java 17 there are some additional settings required when connecting to Ignite:

--add-opens=java.base/jdk.internal.misc=ALL-UNNAMED
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED
--add-opens=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
--add-opens=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
--add-opens=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED
--add-opens=java.base/java.io=ALL-UNNAMED
--add-opens=java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.lang.invoke=ALL-UNNAMED
--add-opens=java.base/java.math=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent.locks=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED
--add-opens=java.sql/java.sql=ALL-UNNAMED
--add-opens=java.base/java.time=ALL-UNNAMED
--add-opens=java.base/java.text=ALL-UNNAMED

In fact, these settings are also necessary when connecting to H2 but using geotools at another point in the project to connect to a Geopackage because geotools circles through all available DB drivers and tries to initialise them (which is probably not best practice?).

Additionally, currently this repository is required:

<repositories>
  <repository>
    <id>HeiGIT main</id>
    <name>Central Repository for OSHDB dependency related artefacts</name>
    <url>https://repo.heigit.org/artifactory/main</url>
  </repository>
</repositories>

Expected Solution

Add that information to the documentation. Also make sure that people who read the documentation on the Helper classes are made aware of this necessity.
@SlowMo24 SlowMo24 added the documentation Readmes, Javadoc, Tutorials, etc. label Apr 19, 2023
@joker234
Copy link
Member

This part is only temporary until we can upgrade to the next ignite version. We didn't update this part on purpose, as it will become irrelevant in the future.

<repositories>
  <repository>
    <id>HeiGIT main</id>
    <name>Central Repository for OSHDB dependency related artefacts</name>
    <url>https://repo.heigit.org/artifactory/main</url>
  </repository>
</repositories>

@SlowMo24 SlowMo24 added the addressing Someone is addressing this issue. You should contact them, before making any contributions. label Apr 19, 2023
SlowMo24 added a commit that referenced this issue Apr 19, 2023
@SlowMo24
docs(installation): add required JVM settings for connection to Ignite (
30ced37 
closes #504)
@SlowMo24 SlowMo24 linked a pull request Apr 19, 2023 that will close this issue
Open
8 tasks
@SlowMo24 SlowMo24 removed the addressing Someone is addressing this issue. You should contact them, before making any contributions. label Apr 19, 2023
tyrasd pushed a commit that referenced this issue Apr 19, 2023
@SlowMo24 @tyrasd
docs(installation): add required JVM settings for connection to Ignite (
219f4c7 
closes #504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Readmes, Javadoc, Tutorials, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(installation): add required JVM settings for connection to Ignite GIScience/oshdb
2 participants
@joker234 @SlowMo24