Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ContributionType checking #499

Open
SlowMo24 opened this issue Mar 27, 2023 · 0 comments
Open

Improve ContributionType checking #499

SlowMo24 opened this issue Mar 27, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@SlowMo24
Copy link
Contributor

Problem Description

Disclaimer: This issue may be based superseded or incomplete knowledge.

AFIK the computation of the ContributionType.GEOMTRY_CHANGE is computation intensive. That's why, if you are not interested in that type, you should use the OSMContribution.is(ContributionType contributionType) method instead of getContributionTypes().

Yet, this method cannot check for empty ContributionType and as #113 was unfortunately closed, I will still have to check for GEOMTRY_CHANGE to filter empty contribs.

Expected Solution

Add a method to check for empty ContributionType.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tyrasd @SlowMo24