Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename geometry-filter "other" to geometrycollection and add more geom-filters #464

Open
SlowMo24 opened this issue Aug 8, 2022 · 3 comments
Assignees

Comments

@SlowMo24
Copy link
Contributor

SlowMo24 commented Aug 8, 2022

Problem Description

The geometry filter "other" is not well defined (at least not in the docu of the ohsome-api). It remains unclear what it contains, apart from geometry-collections.

Expected Solution

Be explicit on the filters. Add filters for Polygon vs MultiPolygon (vs Polygonal) etc.

Alternative Solutions

Document what 'other'-geometry type is.

### Additional Context
Add any other context or screenshots about the feature request here.

Related: #436

@Hagellach37 Hagellach37 added this to To do in oshdb filter via automation Oct 20, 2022
@Hagellach37
Copy link

@tyrasd will check if this is still the case.

@tyrasd
Copy link
Member

tyrasd commented Oct 20, 2022

Yes, the documentation is concise, but IMHO sufficient: ”matches anything which has a geometry of the given type (point, line, polygon, or other)” means that other is everything that is not a point, line or polygon.

Polygon vs MultiPolygon (vs Polygonal)

geometry:polygon is implemented to match everything that is polygonal. I used the simpler wording on purpose in the docs, as it is more easily understandable. Also, I think it's not necessary to provide more detailed filters for only MultiPolygon or non-multi polygonal geometries.

@tyrasd tyrasd closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2022
oshdb filter automation moved this from To do to Done Oct 20, 2022
@SlowMo24
Copy link
Contributor Author

but there is an inconsistency in:

public enum GeometryType {
/** A point geometry (JTS: {@link Puntal}). */
POINT,
/** A line geometry (JTS: {@link Lineal}). */
LINE,
/** A polygon or multipolygon geometry (JTS: {@link Polygonal}). */
POLYGON,
/** A geometry collection which is not a multipolygon. */
OTHER
}

because it links to Puntual/Lineal but only considers Points/Lines. MultiPoint or MultiLinestrings are considered GeometryType.OTHER (if they are even recognised?).

I'm sorry for being such a nit-picker but downstream tools require me to be exact on my geometries.

@SlowMo24 SlowMo24 reopened this Nov 29, 2022
oshdb filter automation moved this from Done to In progress Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
oshdb filter
In progress
Development

No branches or pull requests

3 participants