Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky sidebar toggle test #394

Open
TheGreatRefrigerator opened this issue Aug 11, 2023 · 0 comments
Open

flaky sidebar toggle test #394

TheGreatRefrigerator opened this issue Aug 11, 2023 · 0 comments

Comments

@TheGreatRefrigerator
Copy link
Collaborator

The test for toggling the sidebar fails from time to time and should be more robust:
https://github.com/GIScience/ors-map-client/actions/runs/5831695683/job/15815634155#step:10:381
EmmaHegarty added a commit that referenced this issue Oct 23, 2023
@EmmaHegarty
fix: flaky sidebar test
2ed03eb 
adds test for x button to close sidebar
addresses #394 since the sidebar is now closed again in the previous test and can be re-opened with the toggle
EmmaHegarty added a commit that referenced this issue Oct 24, 2023
@EmmaHegarty
fix: flaky sidebar test
4ba63b7 
adds test for x button to close sidebar
addresses #394 since the sidebar is now closed again in the previous test and can be re-opened with the toggle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheGreatRefrigerator