Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ors.engine.profile_default in ors-config.yml is ignored #1762

Closed
1 task done
jhaeu opened this issue Mar 26, 2024 · 0 comments · Fixed by #1767 · May be fixed by #1778
Closed
1 task done

ors.engine.profile_default in ors-config.yml is ignored #1762

jhaeu opened this issue Mar 26, 2024 · 0 comments · Fixed by #1767 · May be fixed by #1778
Assignees
Labels
Projects

Comments

@jhaeu
Copy link
Contributor

jhaeu commented Mar 26, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

The profile_default properties defined in a user's ors-config.yml are not evaluated correctly. Some routing profiles will not get the default value, even if not overridden in the user's ors-config.yml ors.engine.profiles.:

ors:
  engine:
    profile_default:
      ....: ....

Proposed solution

If properties are defined in profile_default, they should be valid for all enabled profiles, where this specific properties are not specified.

Additional context

No response

Forum Topic Link

No response

@jhaeu jhaeu added the bug 🐛 label Mar 26, 2024
@jhaeu jhaeu self-assigned this Mar 26, 2024
@takb takb added this to To do in ors general Mar 26, 2024
ors general automation moved this from To do to Awaiting release Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
ors general
  
Awaiting release
1 participant