Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some deletions are missing country information #60

Open
Hagellach37 opened this issue Mar 18, 2024 · 1 comment
Open

some deletions are missing country information #60

Hagellach37 opened this issue Mar 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Hagellach37
Copy link
Contributor

Hagellach37 commented Mar 18, 2024

Some contributions of the type deletion are missing the country information. This leads to inconsistent statistics when comparing overall numbers and per country numbers.

Country information is missing for all OSM elements which have been deleted in the sense of OSM:

Country information is only available for deletions in the sense of ohsome:

Solution:

  • need to store country_iso_a3_before information in ClickHouse DB
  • need to use this country information when querying country stats

This is how the data looks in the stream:

{
  "replicationSequence": 6002312,
  "id": "way/1260734826",
  "majorChange": true,
  "current": {
    "info": {
      "version": 2,
      "changeset": 148598030,
      "timestamp": "2024-03-13T14:55:20Z",
      "user": 378610,
      "visible": false
    },
    "tags": {},
    "geometry": "LINESTRING EMPTY",
    "area": 0,
    "length": 0,
    "centroid": [],
    "countries": [],
    "mapFeature": false
  },
  "before": {
    "info": {
      "version": 1,
      "changeset": 148522680,
      "timestamp": "2024-03-11T20:54:25Z",
      "user": 17722275,
      "visible": true
    },
    "tags": {
      "place": "village"
    },
    "geometry": "POLYGON ((22.0044831 13.4230818, 22.0081705 13.4231201, 22.0082149 13.4269849, 22.0067212 13.4306146, 22.004774 13.4304708, 22.0016535 13.4283946, 22.0013035 13.4246881, 22.0044831 13.4230818))",
    "area": 495855,
    "length": 0,
    "centroid": [
      22.004992407803755,
      13.426554962886161
    ],
    "countries": [
      {
        "iso": "TCD",
        "centroid": true
      }
    ],
    "mapFeature": true
  },
  "mapFeatureEditType": -1,
  "deltaArea": -495855,
  "deltaLength": 0,
  "contributionTypes": [
    "DELETION"
  ],
  "changeset": {
    "replicationSequence": 5920609,
    "id": 148598030,
    "createdAt": "2024-03-13T14:55:20Z",
    "closedAt": "2024-03-13T14:55:21Z",
    "closed": true,
    "userId": 378610,
    "user": "Jorieke V",
    "tags": {
      "comment": "#hotosm-project-16297 Mapping of residential land use in #Djokoro, Chad for #missingmaps #msf",
      "source": "Bing",
      "hashtags": "#hotosm-project-16297;#Djokoro;#missingmaps;#msf",
      "created_by": "JOSM/1.5 (18907 en_GB)"
    },
    "hashtags": [
      "Djokoro",
      "hotosm-project-16297",
      "missingmaps",
      "msf"
    ],
    "editor": "JOSM/1.5 (18907 en_GB)"
  }
}
@ElJocho
Copy link
Contributor

ElJocho commented Mar 20, 2024

We have now fixed the bug for all data that is contributed from now on - history data will be fixed at the start of the next week if we do not encounter any unexpected issues. @Jorieke

@ElJocho ElJocho added the bug Something isn't working label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants