Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seek to timestamp possibly off by one #371

Open
djeis97 opened this issue Mar 12, 2024 · 0 comments
Open

Seek to timestamp possibly off by one #371

djeis97 opened this issue Mar 12, 2024 · 0 comments

Comments

@djeis97
Copy link

djeis97 commented Mar 12, 2024

I'm still getting used to working with kafka, so I may have misunderstood the semantics, but it looks like seek-to-timestamp is handling the missing timestamp-offset case incorrectly: I don't think it should increment the end offset (see this line of client.clj).

#198 mentions being concerned about duplicate messages, but if I've understood correctly the endOffsets on a set of partitions are already past the most recent comitted message- the kafka javadocs state they correspond to the offset of the last committed message plus one (i.e. the offset that will be assigned the next message).

Similarly, I'm pretty sure that the test associated with this case should be looking for 10, not 11, since the final message of the test data has offset 9.

Could someone with more experience with kafka's semantics take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant