new Game(engine:Engine, channels:Channels)?

[andretchen0]

I'd like to refactor Game; the details can be subject to further discussion. Generally speaking, as a first step, the bits that could be refactored should be covered by tests, if possible, in order to make sure that changes don't break existing functionality.

Currently however, jest can't load PIXI and Phaser. There are workarounds, but they add complexity.

Instead, I wonder about passing a Phaser instance to Game as an argument. Using dependency injection for the Phaser instance would give the codebase a nudge in the direction of #2021. In the future, another engine - e.g., a homebrew text-based engine - that implements the same interface could be passed instead.

But the short term goal is to make the code more easily testable.

We'd need to:

• create an interface that includes the ways that Phaser is currently used. I propose calling this Engine, though maybe IO works as well.
• create an interface for the messaging system - it currently uses Phaser's Signals, so would mirror those calls for now. I propose calling this Channels.
• both of those will need to be passed to Game's constructor.

[DreadKnight]

Sounds good to me. Things are always best kept decoupled and modular, just in case.