Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sdl connect dialog #9659

Merged
merged 23 commits into from
Dec 20, 2023
Merged

Sdl connect dialog #9659

merged 23 commits into from
Dec 20, 2023

Conversation

akallabeth
Copy link
Member

@akallabeth akallabeth commented Dec 15, 2023 •
edited

  • add a generic connection dialog to show status
  • integrate that dialog to SDL event loop
  • call the dialog with appropriate messages and types (reconnect, connect, ...)
  • add new callback on reconnect (RetryDialog)
  • add signal termination handler to quit SDL on <ctrl>+c et al
  • Timeout for error messages (delay termination to show the user a reason first)
  • prevent termination while a dialog with timeout is shown.
  • add icon drawing capability
  • Add message icons depending on type

TODO: #9666

  • Drawing of dialog message could be improved (a lot) (markup/html)

@akallabeth akallabeth added this to the stable-3.0-next milestone Dec 15, 2023
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10964/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10965/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10966/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10968/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10969/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10972/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10974/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10976/

@akallabeth akallabeth marked this pull request as ready for review December 16, 2023 19:53
@akallabeth akallabeth mentioned this pull request Dec 16, 2023
Open
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10979/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10988/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10990/

@akallabeth
Copy link
Member Author

@freerdp-bot test

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10991/

@akallabeth
Copy link
Member Author

@freerdp-bot test again please

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10994/

@akallabeth
Copy link
Member Author

@freerdp-bot test please

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10996/

@akallabeth
Copy link
Member Author

@freerdp-bot test again...

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10999/

Armin Novak and others added 20 commits December 20, 2023 11:24
@akallabeth
[client,common] call RetryDialog on reconnect
37082ad
@akallabeth
[client,sdl] add connection dialog
37458d7
@akallabeth
[client,sdl] fix ubuntu 20.04 compatibility
ee78d95
@akallabeth
[client,sdl] hide connection dialog
8e13b60 
if another dialog is shown hide the connection dialog.
@akallabeth
[client,sdl] fix smartcard chooser dialog
5f8e5fb
@akallabeth
[client,sdl] improve dialog button highlighting
d776864 
move state to buttons or button list
@akallabeth
[client,sdl] add SDL quit event wrapper
f2f1144
@akallabeth
[client,sdl] improve dialog test drawing
6b3fff8
@akallabeth
[client,sdl] improve connection dialog
49c9118
@akallabeth
[client,sdl] improve file to array helper
b1941da
@akallabeth
[client,sdl] add icon to connect dialog
e3e551a
@akallabeth
[ci,codeql] update dependencies
9def2d1
@akallabeth
[build,mac] add SDL2_image support
d06d951
@akallabeth
[client,sdl] added resource manager
f8ceb57
@akallabeth
[resources] add material icons
3c95080
@akallabeth
[client,sdl] generate binary resources during build
3aa0b21
@akallabeth
[client,sdl] add pre std::filesystem compatibility
2222f90
@akallabeth
[client,sdl] fix c++ static initialization order
a9931bc
@akallabeth
[client,sdl] lock connection dialog access
07fc21a 
might happen from different threads.
@akallabeth
[client,sdl] show a logo on connection dialog
93a97e4 
* Show a icon to indicate the type of message
* Show the FreeRDP logo below the icon
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11031/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11032/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11033/

hardening
hardening approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@hardening hardening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@akallabeth akallabeth merged commit 4617907 into FreeRDP:master Dec 20, 2023
3 checks passed
@akallabeth akallabeth deleted the sdl_connect_dialog branch December 20, 2023 22:16
@akallabeth akallabeth linked an issue Dec 20, 2023 that may be closed by this pull request
[SDL] improve connection dialog #9666
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardening hardening hardening approved these changes

@bmiklautz bmiklautz Awaiting requested review from bmiklautz

@mfleisz mfleisz Awaiting requested review from mfleisz

@pnowack pnowack Awaiting requested review from pnowack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

[SDL] improve connection dialog [SDL] Implement RetryDialog
3 participants
@akallabeth @freerdp-bot @hardening