Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update timezones #10120

Merged
merged 3 commits into from
Apr 23, 2024
Merged

update timezones #10120

merged 3 commits into from
Apr 23, 2024

Conversation

akallabeth
Copy link
Member

@akallabeth akallabeth commented Apr 22, 2024 •
edited

  • Move initialization of settings::ClientTimeZone from rdp_write_client_time_zone to freerdp_settings_new
  • update script generating timezone mappings.

@akallabeth akallabeth added this to the next-3.0 milestone Apr 22, 2024
@akallabeth akallabeth linked an issue Apr 22, 2024 that may be closed by this pull request
API Support for IANA Time Zone String Redirection in FreeRDP #10112
Open
@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@akallabeth akallabeth mentioned this pull request Apr 22, 2024
Open
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11853/

@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11854/

@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11855/

@akallabeth akallabeth marked this pull request as draft April 22, 2024 15:12
@akallabeth akallabeth marked this pull request as ready for review April 22, 2024 15:50
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11860/

@akallabeth
[winpr,timezone] update
ded6c1d 
* update windowsZones.xml url
* update timezones
@akallabeth
[core,timezone] initialize ClientTimeZone early
e1315d8 
Initialize ClientTimeZone in freerdp_settings_new to allow replacing the
default later on in command line parser or client connection callbacks
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11863/

@akallabeth
Copy link
Member Author

@freerdp-bot test again please

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11864/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11865/

@akallabeth
Copy link
Member Author

@freerdp-bot test again please

@akallabeth akallabeth changed the title [client,common] add timezone parameter update timezones Apr 23, 2024
@akallabeth akallabeth removed a link to an issue Apr 23, 2024
API Support for IANA Time Zone String Redirection in FreeRDP #10112
Open
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11868/

@akallabeth akallabeth merged commit 55bd1c2 into FreeRDP:master Apr 23, 2024
6 of 7 checks passed
@akallabeth akallabeth deleted the timezone_setting branch April 23, 2024 07:54
@akallabeth akallabeth linked an issue Apr 23, 2024 that may be closed by this pull request
API Support for IANA Time Zone String Redirection in FreeRDP #10112
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
next-3.6.0
Development

Successfully merging this pull request may close these issues.

API Support for IANA Time Zone String Redirection in FreeRDP
2 participants
@akallabeth @freerdp-bot