Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up the source after stopping #58

Open
dominictarr opened this issue Nov 30, 2019 · 1 comment
Open

clean up the source after stopping #58

dominictarr opened this issue Nov 30, 2019 · 1 comment

Comments

@dominictarr
Copy link

this module implements a stop method:
https://github.com/Fishrock123/bob/blob/master/reference-extension-stop.js

but it doesn't notify the source in anyway. If the source is using a heavy resource, (eg, a file descriptor) the source needs to know the sink has stopped so that it can close the resource.

@Fishrock123
Copy link
Owner

Right, that file is a reference. The source would have to implement it itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants