Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.4 or wait to finish 1.0? #909

Open
KnutAM opened this issue May 13, 2024 · 7 comments
Open

Release v0.4 or wait to finish 1.0? #909

KnutAM opened this issue May 13, 2024 · 7 comments

Comments

@KnutAM
Copy link
Member

KnutAM commented May 13, 2024

Just to have the discussion...

There are some bugs that are fixed on master + some issues with docs (e.g. #908).

It seems like there are some more things that would be good to get into 1.0, so it is still a bit away.

Would an alternative be to release v0.4 now, and then accept that there will be a second round of breaking changes before v1.0 which we could aim to release at/before FerriteCon2024?

@termi-official
Copy link
Member

termi-official commented May 13, 2024

xref https://github.com/Ferrite-FEM/Ferrite.jl/pulls?q=is%3Aopen+is%3Apr+milestone%3Av1.0.0

The GPU PR is likely non-breaking for users so we can delay it.

@koehlerson
Copy link
Member

koehlerson commented May 13, 2024

should #780 be part of 1.0 milestone?

@fredrikekre
Copy link
Member

I think at this point only breaking things should be holding up 1.0. I believe #780 only adds new features right?

@koehlerson
Copy link
Member

https://github.com/Ferrite-FEM/Ferrite.jl/pull/780/files#diff-8db5ed06971ce1004169862f3e499f55666dd630868843be8a53d30ea385e505R110-R119

so this would be okay after 1.0 ?

@KnutAM
Copy link
Member Author

KnutAM commented May 13, 2024

I'm soon posting an extension of @lijas' #789 which will be pretty breaking.
So an argument against releasing an intermediate step (if this should be included) is that this would introduce FacetValues replacing FaceValues, but FaceValues currently replaces FaceVectorValues and FaceScalarValues on master, so that gives two breaking changes which would only be one otherwise...

@KnutAM
Copy link
Member Author

KnutAM commented May 13, 2024

https://github.com/Ferrite-FEM/Ferrite.jl/pull/780/files#diff-8db5ed06971ce1004169862f3e499f55666dd630868843be8a53d30ea385e505R110-R119

so this would be okay after 1.0 ?

Only adding fields isn't breaking AFAIU: code (using public API) that used to work with 1.0 would then still work with 1.1

@termi-official
Copy link
Member

Also #631 is technically breaking for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants