Feature: Undo Variables 'Sort'

[slspencer]

Describe the new feature you would like to see in Seamly
In Measurements->Variables, the Columns can be sorted, but once sorted the columns can't be unsorted.
Add capability to undo the sort and return the variables to the original order.

[DSCaskey]

Will probably require undo / redo commands.

…

On Mon, Mar 20, 2023, 5:19 PM slspencer ***@***.***> wrote: *Describe the new feature you would like to see in Seamly* In Measurements->Variables, the Columns can be sorted, but once sorted the columns can't be unsorted. Add capability to undo the sort and return the variables to the original order. [image: image] <https://user-images.githubusercontent.com/578399/226468366-86db02b8-38a5-40c5-92e8-3caaab8c3ace.png> — Reply to this email directly, view it on GitHub <#893>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHTXADSIJ7M34G7452IZR63W5DCX3ANCNFSM6AAAAAAWBUCYUE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[DSCaskey]

So the question is...

Do you want to just restore a single column to unsorted - leaving any other columns that may be sorted left alone?

Or would a "restore" button that just refills the table with the default data suffice? The latter is easy to do... the former is way more involved as the QTableWidget does not support an unsorted option - just ascending and descending - therefore requiring subclassing the data model to handle that option.

[DSCaskey]

Add capability to undo the sort and return the variables to the original order.

Ok... there's more to the issue.

Since a user can manually move items up / dn in one of the tables... exactly what is the "orginal" order? Would that be the order in which the pattern was loaded, and subsequently the Variables table opened? Or Does it mean the order just prior to sorting... which could be different from the order in which the pattern was loaded if it hasn't been saved yet. In the true sense of Undo - IMO that would be the order just prior, where as Resetting would be the order as last saved.

[slspencer]

Can't prevent user error, but I've seen this on webapps: Provide a confirmation "Are you sure?" popup message with an additional checkbox for "Don't show again".

[DSCaskey]

??? I have no clue what a pop up has to do with restoring a sort order?

[slspencer]

When the 'Restore' button is selected then a popup window asking the user if they're sure might be a good solution low-code solution to your concerns.
We can prevent most disasters with this approach. I see it in apps frequently enough that it seems to be an industry practice.
Maybe I was thinking the Restore button would be enabled for edits, moves, deletes. Maybe this is incorrect thinking.

The Restore button is sufficient.

[DSCaskey]

Not sure what diasters sorting / unsorting the variables table could cause? I just checked... if you want to restore any of the Variables Table order, just close it and reopen it. It doesn't save any Sort you may have performed... other than if you Move a custom variable.

…

On Sat, Mar 25, 2023, 9:41 PM slspencer ***@***.***> wrote: When the 'Restore' button is selected then a popup window asking the user if they're sure might be a good solution low-code solution to your concerns. We can prevent most disasters with this approach. I see it in apps frequently enough that it seems to be an industry practice. — Reply to this email directly, view it on GitHub <#893 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHTXADUKPNCX3DFB3EJFAKTW56NFJANCNFSM6AAAAAAWBUCYUE> . You are receiving this because you commented.Message ID: ***@***.***>

[slspencer]

Closing and reopening the window to refresh the data to the original order is aggravating. Your suggestion for Restore button is good.

If the Restor button truly restores from the currently saved state then it can be enabled whenever a change has happened, like edit, move, delete, add but user decides to discard changes.