Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3DXRD/S3DXRD notebooks should contain no complicated functions #246

Open
jadball opened this issue Mar 6, 2024 · 3 comments
Open

3DXRD/S3DXRD notebooks should contain no complicated functions #246

jadball opened this issue Mar 6, 2024 · 3 comments
Assignees

Comments

@jadball
Copy link
Contributor

jadball commented Mar 6, 2024

The purpose of the notebooks should just be to choose the data to process and plot the results of that processing.
This will make creating workflows much easier.
This process should happen in two stages:

  1. Move functions out of notebooks into nb_utils.

This ensures that the functions work from a standalone Python file

  1. Move the functions from nb_utils into existing/new parts of ImageD11
@jadball
Copy link
Contributor Author

jadball commented Mar 13, 2024

#251 removed functions from notebooks

#257 worked out where the functions should go

Current task is to actually move them into ImageD11

@jadball
Copy link
Contributor Author

jadball commented Mar 15, 2024

@jonwright I have made some progress in distributing the functions into ImageD11 in my fork if you want to have a look:
https://github.com/jadball/ImageD11

However, it's still in progress so I wasn't planning on making a PR yet.
Do you anticipate any core changes to ImageD11 early next week? If so, I could submit a PR now to maintain linearity while i'm away next week.

@jonwright
Copy link
Member

Just saw this - feel free to merge. I think I added something to speed up updateGeometry but there should be no conflicts.

@jadball jadball self-assigned this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants