-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new-backend] Fix unit tests #4487
Comments
@eiskasten Thank you very much for kicking off this issue 🚀 💞 @atmaxinger can you give some input about the extra tests that failed after merging #4471? |
The problem lies in bool goptsActive = handle->globalPlugins[PROCGETSTORAGE][MAXONCE] != NULL; Which doesn't really tell you if libelektra/src/libs/elektra/kdb.c Lines 1780 to 1794 in 3e9f5ed
So this is more or less a bug/works-by-accident behaviour of the |
Yes, the Also AFAICT What this |
@eiskasten there are also quite a few tests in Some of them are tests for old data structures that aren't used anymore. In those cases, there might not yet be tests for the new data structures. libelektra/tests/ctest/test_mount.c Lines 15 to 17 in fac8496
Other tests, check behaviour that has changed a bit libelektra/tests/kdb/testkdb_simple.cpp Lines 87 to 89 in fac8496
|
@kodebach do we actually have tests for the spec plugin testing the bahaviour as global plugin that I can repurpose for the hooks? The two I found (test_spec and testmod_spec) all pass. But there must be some tests in elektra that actually test the behaviour of kdbGet and kdbSet with spec, right? |
Tests for how If you want tests for just the hook, you should probably copy what you did for |
@eiskasten I'll fix |
Ok, thank you, I will have a look on them. |
Do you suggest removing them? I tried to run them but they are not compiling anymore. I commented the non-compiling parts but they running them still fails due to substantial changes in the backend. |
Yes, you can remove all tests that are related to Instead of these tests, we now need to test the (non-
The other functions should do:
For Re priorities: Adding tests for |
@eiskasten @kodebach What can we realistically do here before the next release hopefully coming soon (January)? |
I personally, won't have the time. Since I'm still focusing on the decisions. When those are finished (whenever that may be), I might find time. However, there is not that much left, so I believe somebody else could still make progress in January (or at least Feburary). Regarding tests, I found these somewhat important FIXMEs:
There are also a few less important FIXMEs/TODOs:
|
@eiskasten can you please update the top-post for which tests still need fixes? |
I have updated the state of the tests |
@eiskasten is there something that can go into the next release? |
Nothing I know about from |
I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue. |
I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue. |
Lots of tests currently fail in the master branch (c560182).
Expected Result
All tests should pass
Actual Result
The following tests are failing:
The following tests are (partially) disabled:
The state of the following tests is currently unknown to me:
I will add further logs and information in a comment per testsuite. This should make the discussion make much more clear. If a testsuite is fixed, it can be checked in this list.
System Information
The text was updated successfully, but these errors were encountered: