Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-app documentation does not respect document encoding #785

Open
smallg0at opened this issue Sep 21, 2023 · 4 comments
Open

In-app documentation does not respect document encoding #785

smallg0at opened this issue Sep 21, 2023 · 4 comments

Comments

@smallg0at
Copy link
Contributor

In-app documentation does not respect document encoding currently, which will affect Chinese documentation display specifically when not using msi distribution & Java encoding is not utf-8 (once #772 is merged).

image

@lupino3
Copy link
Member

lupino3 commented Sep 21, 2023

Can you confirm that it works if you run java -Dfile.encoding=UTF8 -jar <path to JAR>?

@smallg0at
Copy link
Contributor Author

Can you confirm that it works if you run java -Dfile.encoding=UTF8 -jar <path to JAR>?

Java throws java.lang.ClassNotFoundException: /encoding=UTF-8 error.

@lupino3
Copy link
Member

lupino3 commented Oct 28, 2023

On Windows, it needs to be run like this: java -D"file.encoding"=UTF8 -jar .\edumips64-1.3.0.jar. The MSI has the right settings.

lupino3 added a commit that referenced this issue Oct 28, 2023
@lupino3
Copy link
Member

lupino3 commented Oct 28, 2023

I'm thinking that the only way to prevent this problem would be to avoid using the File API at all to load the help. Much like we do for localization. I am not sure if this is possible, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants