Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up RegisterFP #704

Open
lupino3 opened this issue Sep 4, 2022 · 0 comments
Open

Clean up RegisterFP #704

lupino3 opened this issue Sep 4, 2022 · 0 comments
Assignees
@lupino3
Labels
component:core priority:1 type:internal-cleanup

Comments

@lupino3
Copy link
Member

lupino3 commented Sep 4, 2022

There is code duplication in RegisterFP, as it doesn't inherit from Register.

We should move BitSet64FP features to BitSet and make RegisterFP extend Register. This will allow us not to duplicate code for the upcoming delayed unlock feature necessary for #702.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lupino3 lupino3

Labels
component:core priority:1 type:internal-cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lupino3