Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also run tests against docker container #409

Open
LexLuengas opened this issue Dec 15, 2022 · 0 comments · May be fixed by #410
Open

Also run tests against docker container #409

LexLuengas opened this issue Dec 15, 2022 · 0 comments · May be fixed by #410

Comments

@LexLuengas
Copy link
Collaborator

Currently

Almost all integration tests run against local server instances (server.listen() on the main process) of the proxy and the mock.

This means that problems specific to the Docker image build are not caught by the tests. Issues like #401 will go unnoticed.

This change will...

  • Build the Docker container before the tests are run.
  • Re-run integration tests also against the Docker container of openapi-cop.
@LexLuengas LexLuengas linked a pull request Feb 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant