Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the channel we're getting points from - in the Output log #297

Open
notNSANE opened this issue Sep 6, 2023 · 2 comments
Open

Add the channel we're getting points from - in the Output log #297

notNSANE opened this issue Sep 6, 2023 · 2 comments
Labels
Enhancement New feature or request

Comments

@notNSANE
Copy link

notNSANE commented Sep 6, 2023

Seems like a simple feature but it should be really helpful to immediately understand if we're not getting points from a channel we want to.

@DevilXD DevilXD added the Enhancement New feature or request label Sep 7, 2023
@DevilXD
Copy link
Owner

DevilXD commented Sep 7, 2023

Hello o/

From this, I'm reading that your suggestion is to turn this:

Earned points for watching: {earned}, total: {total}

..., into this:

Earned points for watching {channel}: {earned}, total: {total}

If so, then I'm okay with the change. However, the existing translations would need to be updated to include this change as well. This can be either required for this issue to close, or be considered "extra information" to-be-used for when someone would update a translation in the feature - this would prevent translations from blocking this issue.

I'm leaning towards updating all translations now rather than later, but first I'd like you to confirm this is what you want to be added.

@notNSANE
Copy link
Author

notNSANE commented Sep 7, 2023

Exactly that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants