Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contour detection: unexpected results outside ROI #34

Closed
PierreRaybaut opened this issue Jan 18, 2024 · 2 comments
Closed

Contour detection: unexpected results outside ROI #34

PierreRaybaut opened this issue Jan 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@PierreRaybaut
Copy link
Contributor

PierreRaybaut commented Jan 18, 2024

In DataLab, the "Computing > Contour detection" feature is based on scikit-image skimage.measure.find_contours as described in this tutorial.

image

When performing a contour detection on a ROI (which is a NumPy masked array in DataLab's model), some results still appear outside the ROI and should be ignored:

image

This issue is related to Issue #32.

@PierreRaybaut PierreRaybaut added the bug Something isn't working label Jan 18, 2024
@PierreRaybaut
Copy link
Contributor Author

PierreRaybaut commented Jan 18, 2024

Now, thanks a workaround, the erroneous contours are filtered out.

A new test module cdl.tests.features.images.contour_fabryperot_app has been added to test the contour detection feature on a Fabry-Perot image (thanks to @emarin2642 for the contribution)

image

@PierreRaybaut
Copy link
Contributor Author

I've just opened an issue on scikit-image GitHub project, in case it's relevant:
scikit-image/scikit-image#7300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant