Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DCT and DST into DTT #151

Open
DejvBayer opened this issue Jan 18, 2024 · 4 comments
Open

Merge DCT and DST into DTT #151

DejvBayer opened this issue Jan 18, 2024 · 4 comments

Comments

@DejvBayer
Copy link

Hi,

I was wondering if it would be possible to merge DCT and DST computation into single DTT type where you could select the right DTT type for each axis (same as FFTW). It would help me a lot, because in our project we mix different DCT and DST types.

Thanks a lot!

David

@DejvBayer DejvBayer changed the title Feature request: Merge DCT and DST into DTT Merge DCT and DST into DTT Jan 18, 2024
@DTolm
Copy link
Owner

DTolm commented Jan 18, 2024

Hello,

Sure, this is not hard to add. I will keep the legacy functionality and just add another parameter performDTT[fftDim] that will take predefined values VKFFT_REDFTXX/VKFFT_RODFTXX like FFTW_REDFTXX/FFTW_RODFTXX in FFTW.

Best regards,
Dmitrii

@DejvBayer
Copy link
Author

That would be awesome! However I would consider naming it performR2R[fftDim] in case any other transforms R2R are added in the future.

Thank you very much.

David

DTolm added a commit that referenced this issue Feb 6, 2024
@DTolm
Copy link
Owner

DTolm commented Feb 6, 2024

I have added performR2R option. It passed quick simple tests and should work (as it didn't require any new algorithms).

@DejvBayer
Copy link
Author

Great job! Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants