Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json.Net for deserialization #3

Open
JohnnyFun opened this issue Aug 15, 2017 · 4 comments
Open

Json.Net for deserialization #3

JohnnyFun opened this issue Aug 15, 2017 · 4 comments

Comments

@JohnnyFun
Copy link

Hi,

Firstly, thanks for implementing patch operations! It's exactly what I need for what I'm doing.

One question: is there a way I can easily substitute in json.net instead of JavaScriptSerializer? Or do you know if someone has forked and made that change or is working on it?

Thanks,

-John

@xt0rted
Copy link

xt0rted commented Aug 15, 2017

If you're using asp.net core and nancy v2 then this might be a good option as it uses json.net jchannon/Nancy.JsonPatch.Core

@JohnnyFun
Copy link
Author

Shoot, we're on .net 4.5 for this particular project. Thanks for the suggestion though

@DSaunders
Copy link
Owner

Sorry for the slow reply, not sure why I didn't get a notification for this.
Assuming it's not too late...

It's not currently possible, but wouldn't be too difficult. We would need to implement a new version of JsonPatchDocumentParser, and add some way of allowing it to be swapped out (probably a new extension method in JsonPatchModuleExtensions).

Let me know if I can help any more.. all pull requests will be gratefully received 😄

@JohnnyFun
Copy link
Author

No worries, Dave. I was also able to work around the issue I ran into, so it all worked out.

I just finished up the project that I used it in, and its working great for what we need with my workaround. Later on, I'll consider doing a pull request with something like what you mentioned, but if I do it'll honestly be a while--hopping on a new project with kind of a tight deadline. So it goes...

Thanks for your input and of course for writing the library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants