Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library/includes/wdirent.h may be out of date #4602

Open
ab9rf opened this issue May 17, 2024 · 3 comments
Open

library/includes/wdirent.h may be out of date #4602

ab9rf opened this issue May 17, 2024 · 3 comments

Comments

@ab9rf
Copy link
Member

ab9rf commented May 17, 2024

this include was obtained from tronkko/dirent sometimes around 2011 when it was designed for use with MSVC 6.0. there's been some updates since then in the original source and we're long past MSVC 6.0

@myk002
Copy link
Member

myk002 commented May 17, 2024

should we be depending on a local fork of https://github.com/tronkko/dirent instead? it looks like there are (relatively) recent releases

@ab9rf
Copy link
Member Author

ab9rf commented May 17, 2024

i don't think that would be a bad approach

i dunno if there are material changes between what we're using and what is in tronkko's repo; i haven't looked that closely, and this isn't necessarily causing problems. mostly i was looking at this just to understand what it was and why it's there

@myk002
Copy link
Member

myk002 commented May 17, 2024

yeah, I was confused too. at least moving it to depends would make it clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants