Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Use rich instead of tqdm #19

Open
F-park opened this issue Dec 3, 2023 · 4 comments
Open

[FR] Use rich instead of tqdm #19

F-park opened this issue Dec 3, 2023 · 4 comments
Labels
feature request New feature or request

Comments

@F-park
Copy link

F-park commented Dec 3, 2023

Future Request Reason

rich can make console colorful, both text and progress, I think it adapts this project.

Solution

If you agree this change, I will work in #17

@CrypticSignal
Copy link
Owner

CrypticSignal commented Dec 3, 2023

You can replace tqdm with rich, as long as (at minimum) we still have a progress bar, percentage progress and estimated time until completion.

@CrypticSignal CrypticSignal changed the title [FR] Use rich to instead tqdm [FR] Use rich instead tqdm Dec 3, 2023
@CrypticSignal CrypticSignal changed the title [FR] Use rich instead tqdm [FR] Use rich instead of tqdm Dec 3, 2023
@F-park
Copy link
Author

F-park commented Dec 3, 2023

You can replace tqdm with rich, as long as (at minimum) we still have a progress bar, percentage progress and estimated time until completion.

Thanks, but it will cost me some time to read the document of rich, I will work it soon.

@CrypticSignal
Copy link
Owner

@F-park You don't need to add this in #17, I can work on this myself one day.

@F-park
Copy link
Author

F-park commented Dec 3, 2023

@F-park You don't need to add this in #17, I can work on this myself one day.

OK

@CrypticSignal CrypticSignal added the feature request New feature or request label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants