Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation jumpy #10

Open
zoneblaze opened this issue Mar 23, 2016 · 4 comments
Open

Rotation jumpy #10

zoneblaze opened this issue Mar 23, 2016 · 4 comments

Comments

@zoneblaze
Copy link

Hey Andrew, I've had a play with those updates, seems to work really well, I've only come across one issue so far, rotating/animating nodes have become all jumpy, e.g. something like node.setRotation(0,0,this.RotTransition.get());

@CompSciFutures
Copy link
Owner

I suspect its because the frame rate is throttled to 15 FPS ? You can change the FPS with:

var famous = require("refamous");
famous.core.FamousEngine.renderLoop._FPSCounter.setTargetFPS(30.0);

What operating environment are you using? I haven't noticed it on Windows but your app could be different? Certainly interested to hear.

ap

@zoneblaze
Copy link
Author

Seen it on windows/mac etc... will try and set up an example asap

@CompSciFutures
Copy link
Owner

@zoneblaze, did changing the frame rate help at all?

I had a think about it and it could be a discretisation issue with the way we have done some of the performance tweaks. I'm thinking catastrophic cancellation or truncation errors.

If changing the FPS doesn't fix it, then a little example that reproduces the problem you are having (regardless of the frame rate) would be useful.

@zoneblaze
Copy link
Author

Hi @Aprender I haven't looked at the FPS, my guess is the performance tweaks maybe too ambitious in some cases and truncating rounding values causing the "jumpiness". I've set up an example using the original boilerplate. You should see their logo rotating. Here's the original Famous: http://zonkzone.net/test/rotation/famous/ and here's refamous which isn't behaving as well http://zonkzone.net/test/rotation/refamous/ do you get that as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants