Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SampleApp] GitHub icon not centered (NIT) #4489

Open
3 of 14 tasks
marcelwgn opened this issue Feb 16, 2022 · 5 comments · May be fixed by #4494
Open
3 of 14 tasks

[SampleApp] GitHub icon not centered (NIT) #4489

marcelwgn opened this issue Feb 16, 2022 · 5 comments · May be fixed by #4494
Assignees
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior In-PR 🚀 sample app 🖼

Comments

@marcelwgn
Copy link
Contributor

Describe the bug

The GitHub icon is not centered inside the button. While this is not visible on its own, when hovering over the icon, the imbalance is visible:
GitHub icon not centered inside the "Open on GitHub" button

Regression

No response

Reproducible in sample app?

  • This bug can be reproduced in the sample app.

Steps to reproduce

1. Checkout CommunityToolkit repository
1. Build and launch Sample app
1. Navigate to any sample

Expected behavior

The icon should be centered.

Screenshots

No response

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

Windows 10 Insider Build 19044

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

2022

Visual Studio Build Number

No response

Device form factor

Desktop

Nuget packages

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

@marcelwgn marcelwgn added the bug 🐛 An unexpected issue that highlights incorrect behavior label Feb 16, 2022
@ghost ghost added the needs triage 🔍 label Feb 16, 2022
@ghost
Copy link

ghost commented Feb 16, 2022

Hello chingucoding, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@michael-hawker
Copy link
Member

Thanks @chingucoding! I may be pushing an update out to the sample app soon for the DataGrid issue, so if you'd like to submit a PR, feel free.

Otherwise, as you know from our #4486 memo, we'll be redoing a lot of the infrastructure and that should replace our current sample app. Happy to have your input and advice as we move forward in those directions. Hopefully we'll be ready in the next week or so to invite any of our longstanding community collaborators to help provide feedback and test things out before we make our new Labs repo public.

@marcelwgn
Copy link
Contributor Author

Sure thing. If you think it would be better to wait the infrastructure rethinking and Toolkit Labs, I would also be more than happy to wait for that. Let me know what you think!

@michael-hawker
Copy link
Member

@chingucoding if you think it'll just take you 10 minutes and you want to get a quick fix in, then happy to do it now for the patch of the sample app. But since it's a minor nit, I'm fine if we just leave it for now too. 😋

@marcelwgn
Copy link
Contributor Author

Yeah it shouldn't take too much time to fix, I'll get right to it.

@marcelwgn marcelwgn linked a pull request Feb 17, 2022 that will close this issue
13 tasks
@ghost ghost added the In-PR 🚀 label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior In-PR 🚀 sample app 🖼
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants