-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notifications] support for StreamingHTTPChannel2023 #1574
Comments
Would advise waiting until the v0.2.0 PR is merged #1565. The majority of the notification work is done by generic classes so specific channel types only have to implement the parts specific to them. At a first glance the biggest part for this one would be to support authorized GET requests on the
This is the part that would make things more difficult as currently we only do discovery through the storage description resource, not the metadata of specific resources. I have been thinking of adding that as well in the future but would require some internal changes to support adding custom metadata on a per-resource basis. |
Thank you @joachimvh, I'm definitely going to wait for #1565 to land first! I see no problem with first adding support for Streaming HTTP on par with the support for Websockets, later iterating on adding more features.
I'm planing to create issue on the notifications spec to make AuthN explicit for each channel. This way we can also use Capability URL for Streaming HTTP notification channels, later enabling ones which rely on Solid-OIDC directly on Given all above I would see 3 iterations for Streaming HTTP support:
Each step only enables additional functionality without changing functionality added in a previous step. Does it sound reasonable? |
Note that when I say this would be the biggest part I don't see it as being a big hurdle, but more that this is the main part for which an extra class would be needed. But this should not be a major issue when implementing since it can reuse the authorization functionality already in CSS (which is what happens when subscribing). So immediately going to step 2 would be fine. CommunitySolidServer/src/server/notifications/NotificationSubscriber.ts Lines 97 to 107 in 9a64095
|
I see the upcoming documentation for WebSocketChannel2023, this is very helpful! |
I might be able to work on this feature by adding it as an extra task to a project with NLnet, which I'm currently wrapping up. If it happens, I hope to have StreamingHTTP available before the Solid Notifications session planned for https://events.vito.be/sosy2024 To make it more clear how it differs from WebSocket, I plan on taking the following approach:
I still need to look at how the handler of |
Feature description
I would like to collaborate on adding support for StreamingHTTPChannel2023
The main differences from WebSocketChannel2023 are:
https://
and the server streams response to the client (minimal examples of server and client)If someone from CSS team would like to lead the effort I'm more than happy to provide any support needed, including changes to the channel type draft. Otherwise I could try to tackle it myself but I would most likely need some guidance on how CSS handles notifications and AuthN/AuthZ internally.
The text was updated successfully, but these errors were encountered: