-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorthand configuration #1647
Comments
I get where you're coming from, but this is a not a trivial problem for several reasons. The JSON config above allows users to set CLI parameters through their No matter which we pick, one of the first issues is that to parse CLI parameters we already need to have a Components.js configuration, as what the CLI parameters are and how they should be interpreted is also defined in the config. But the Another thing would be how to interpret it. In your instance you give the server a config, All the logic of how options map to specific configuration formats are also solely in the configuration generator repository, the CSS repo has no idea about this. So these would then have to be merged. The configuration generator codebase is of much lower quality than this one, and has drastic architectural changes if I think of something new, which would make it not that great of a fit to be in here. Having it separate and work as it currently does also allows me to move much faster in that repo if changes are needed. One thing that could be done and would be much easier would be to add a tool to the config repo that parses a JSON file from the CLI with the necessary options, and outputs a valid CSS config. This could then potentially be chained with a script to feed it into CSS. That would be an issue for the generator repo then. |
Feature description
Now that https://communitysolidserver.github.io/configuration-generator/v6/ exists I feel that it would be quite useful to make that config generation logic a feature of startup, where the values entered in the UI can instead be part of this JSON config for the CSS and the output config is just generated internally to startup the server.
For instance a CSS instance with ACP might have a config looking like
The text was updated successfully, but these errors were encountered: