Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units of tau_osm and tau_noc are incrrect #51

Open
bishtgautam opened this issue Nov 23, 2021 · 0 comments
Open

Units of tau_osm and tau_noc are incrrect #51

bishtgautam opened this issue Nov 23, 2021 · 0 comments

Comments

@bishtgautam
Copy link

The Units of tau_osm at canopylayer.jl#L163 is incorrectly listed as [μmol⁻¹].
The units of tau_osm should be [mol² m⁻² s⁻² μmol⁻¹] based on the following calculation:

d(g_sw)/dt = [mol m⁻² s⁻¹]/s = [mol m⁻² s⁻²]
(dA/dE – d\Theta/dE) = [μmol  m⁻² s⁻¹] / [mol m⁻² s⁻¹] = [μmol mol⁻¹]
tau_osm = [mol² m⁻² s⁻² μmol⁻¹]
Yujie-W added a commit that referenced this issue Oct 31, 2022
51: fix a version typo r=Yujie-W a=Yujie-W



Co-authored-by: Yujie Wang <jesiner@gmail.com>
Yujie-W added a commit that referenced this issue Oct 31, 2022
51: Wyujie r=Yujie-W a=Yujie-W



Co-authored-by: Yujie Wang <jesiner@gmail.com>
Yujie-W added a commit that referenced this issue Oct 31, 2022
51: Wyujie r=Yujie-W a=Yujie-W



Co-authored-by: Yujie Wang <jesiner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant