Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplyShadow result discarded during shader creation #2167

Open
ajtribick opened this issue Apr 4, 2024 · 1 comment
Open

ApplyShadow result discarded during shader creation #2167

ajtribick opened this issue Apr 4, 2024 · 1 comment

Comments

@ajtribick
Copy link
Collaborator

The result of the ApplyShadow call here isn't used.

if (props.hasShadowMap() && i == 0)
ApplyShadow(false);
}

Need to check what this does and either append the code to source or remove the call.

@375gnu
Copy link
Member

375gnu commented Apr 5, 2024

oh, source += was lost when ApplyShadow was added to avoid code duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants