Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update children positions when parent body is modified #1832

Open
375gnu opened this issue Aug 6, 2023 · 6 comments
Open

Update children positions when parent body is modified #1832

375gnu opened this issue Aug 6, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@375gnu
Copy link
Member

375gnu commented Aug 6, 2023

At least with the build from the pull request, locations on Ceres are fixed with its actual oblateness, but I just found that if I modify an object to increase its oblateness to 0.5, locations are still floating in space:
flatmars

Originally posted by @SevenSpheres in #1557 (comment)

@375gnu 375gnu added the bug Something isn't working label Aug 6, 2023
@375gnu
Copy link
Member Author

375gnu commented Aug 8, 2023

@SevenSpheres are you sure that you tested a proper build? That's what I have with the today's master:
image

@munix9
Copy link
Contributor

munix9 commented Aug 8, 2023

works for me too (linux/qt5/master)
blubb

@SevenSpheres
Copy link
Contributor

Still looks like my screenshot on the latest build. Tested on Win32, Qt5, and Qt6 frontends.

@ajtribick
Copy link
Collaborator

I can reproduce both cases.

  • If you edit the oblateness of Mars by editing solarsys.ssc, the location positions work.
  • If you set it via a modification rule, e.g. Modify "Mars" "Sol" { Oblateness 0.5 } then the location positions will not be updated and will be floating in space.

@SevenSpheres
Copy link
Contributor

Can confirm, so this is probably a non-issue

@ajtribick ajtribick changed the title With increased oblatesness locations are still floating Location positions do not take into account modification of the oblateness Aug 9, 2023
@375gnu
Copy link
Member Author

375gnu commented Aug 10, 2023

Then we need to recompute children positions on modification.

@375gnu 375gnu changed the title Location positions do not take into account modification of the oblateness Update children positions when parent body is modified Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants