Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent mixed results between earth_search and earth_search_cog #364

Open
1 task
sbrunato opened this issue Nov 23, 2021 · 0 comments · May be fixed by #414
Open
1 task

prevent mixed results between earth_search and earth_search_cog #364

sbrunato opened this issue Nov 23, 2021 · 0 comments · May be fixed by #414
Assignees
Labels
bug Something isn't working
Projects

Comments

@sbrunato
Copy link
Collaborator

sbrunato commented Nov 23, 2021

See #362 .

@GriffinBabe pointed out that if we omit to specify the product type when searching on earth_search_cog, we get also results from earth_search that cannot be downloaded with the wrong download plugin:

from eodag import EODataAccessGateway

dag = EODataAccessGateway()
dag.set_preferred_provider("earth_search_cog")

# Here I forget to specify which productType I am looking for
cog_products, _ = dag.search()
path = dag.download(cog_products[0])

Raises

requests.exceptions.InvalidSchema: No connection adapters were found for 's3://sentinel-s2-l2a/tiles/42/F/UK/2021/11/23/0/qi/L2A_PVI.jp2'

To prevent this, we'd have to:

  • only accept S2_MSI_L2A_COG product type with earth_search_cog
  • filter out S2_MSI_L2A_COG product type with earth_search
  • remove earth_search_cog and add S2_MSI_L2A_COG to earth_search
@sbrunato sbrunato added the bug Something isn't working label Nov 23, 2021
@sbrunato sbrunato added this to Needs Triage in eodag.* via automation Nov 23, 2021
@sbrunato sbrunato moved this from Needs Triage to priority::1 in eodag.* Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
eodag.*
  
priority::1
Development

Successfully merging a pull request may close this issue.

1 participant