Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing processors import #534

Open
lucainiaoge opened this issue Dec 20, 2023 · 4 comments
Open

Changing processors import #534

lucainiaoge opened this issue Dec 20, 2023 · 4 comments

Comments

@lucainiaoge
Copy link

Problem

ImportError: cannot import name 'MutableSequence' from 'collections' (......./conda_envs/thesis/lib/python3.11/collections/init.py)

Solution

Changing madmom/processors.py import

if sys.version_info[:2] >= (3, 8):
from collections.abc import MutableMapping
else:
from collections import MutableMapping

@aRI0U
Copy link

aRI0U commented Jan 17, 2024

Hi!
Since this issue is quite annoying but very easy to fix, I'd be happy to submit a PR fixing it. Does it sound good to you?
Thanks!

@superbock
Copy link
Collaborator

Yes, absolutely! This kind of issues are easy to fix, the problem still being the outdated CI pipeline, which should be fixed first. Since I'm always short on time, any PR addressing this is also greatly appreciated 🙏

@aRI0U
Copy link

aRI0U commented Jan 17, 2024

Oh actually I just realized that this import issue has already been fixed in the main branch, however when you install madmom with pip it is an older version of the code. I guess the current solution to this specific issue is just to install madmom from source for now.

Not sure to have fully understood the outdated CI issue, however on my laptop branch main passes all tests (Ubuntu 22.04 + Python 3.10) just with pytest, no need to pass option --doctest-ignore-import-errors as in the CI workflow.

@superbock
Copy link
Collaborator

The problem is that we do not have a working CI pipeline on Github, something I'd like to have in place before merging stuff into main. Once this is done, we can work through the open PRs and fix stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants