Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route wildcard naming #68

Open
johan-forsell opened this issue Jan 22, 2020 · 5 comments
Open

Route wildcard naming #68

johan-forsell opened this issue Jan 22, 2020 · 5 comments
Labels
enhancement New feature or request low priority ⬇️ I'm not planning on it.
Milestone

Comments

@johan-forsell
Copy link

First off; Thank you for developing this fine project! :)

However, we had quite some trouble getting the library to work for us.

Thing was that in Ocelot the route wildcards can be named whatever. In our case they were named {path} and Ocelot-wise that was all working fine. However after some debugging we found that SwaggerForOcelot does not allow this, and will only accept wildcards named {everything}.

My suggestion would be to either implement a fix that allows any wildcard naming, like Ocelot do, or to expressively state in the documentation that only the {everything} wildcard tag is supported.

It might help others 👍

@Burgyn
Copy link
Owner

Burgyn commented Jan 22, 2020

Hi,

thanks for your issue.

Yes, unfortunately now this project support only {everything} as wildcard. I plan implemented this feature, but after issue #56. I don't have as much time as I would imagine.

Thanks a lot.

@Burgyn Burgyn added the enhancement New feature or request label Jan 22, 2020
@Burgyn Burgyn added this to the Version 2.0 milestone Jan 22, 2020
@johan-forsell
Copy link
Author

I understand completely.

If I manage to conjure up some time myself, I'll implement the solution and send a PR.
Should take some load off...

Thank you for your comitment :)

@dgustala
Copy link

dgustala commented Jan 6, 2022

Hi,

thanks for your issue.

Yes, unfortunately now this project support only {everything} as wildcard. I plan implemented this feature, but after issue #56. I don't have as much time as I would imagine.

Thanks a lot.

Hi, thanks for all your effort!
I have a question: you said above that you only support {everything} as wildcard.
But in the this example: https://github.com/Burgyn/Sample.OcelotWithRoutingParameters/blob/master/src/ApiGateway/ocelot.json
..you use both {everything} and {companyId} as wildcards. That's correct?

@Burgyn
Copy link
Owner

Burgyn commented Jan 7, 2022

Hi @dgustala,

in this case {companyId} is not "wildcard", but a path parameter. If the same parameter at the same position exists in the downstream path, the documentation can be shown.

@dgustala
Copy link

dgustala commented Jan 7, 2022

Good to know. Thanks!
And what about query parameters? Works in the same way than path parameters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority ⬇️ I'm not planning on it.
Projects
None yet
Development

No branches or pull requests

3 participants