Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory tree hashing should be improved #281

Open
jkloetzke opened this issue Nov 13, 2019 · 2 comments
Open

Directory tree hashing should be improved #281

jkloetzke opened this issue Nov 13, 2019 · 2 comments

Comments

@jkloetzke
Copy link
Member

Whem Bob has to hash a multi-GB workspace it will be stuck for a long time. It also looks like the current algorithm does not handle caching very well if parts of the workspace are updated. The re-hashing still takes very long even though the cache miss rate should be negligible.

  • There may be a bug in the cache handling in face of partial workspace changes
  • There should be some user feedback if hashing takes very long
  • The cache may be improved by compressing common prefixes (like git does)
@mahaase
Copy link
Contributor

mahaase commented Dec 18, 2019

I guess, this ticket and #262 are the same?
Could we mark one of them as duplicte?

@jkloetzke
Copy link
Member Author

Actually not. This ticket is about a suspected inefficiency in the algorithm. The other ticket is about the fact that on MSYS on Windows Bob cannot use the right syscalls and is very slow because of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants