Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the filename is correctly encoded in the S3 bucket #4941

Closed
imsdu opened this issue May 6, 2024 · 1 comment
Closed

Make sure that the filename is correctly encoded in the S3 bucket #4941

imsdu opened this issue May 6, 2024 · 1 comment

Comments

@imsdu
Copy link
Contributor

imsdu commented May 6, 2024

Motivation
Filenames can sometimes create special characters which are url-encoded.
Akka urls .toString encode them by default and the S3 sdk may encode them a second time

Acceptance criteria

  1. Make sure that filenames are not url-encoded twice
@shinyhappydan
Copy link
Contributor

In order to play this story I would need an example. What is the scenario where this could occur? What should the filename look like on S3?

For example, if the user supplies a filename which is my file.txt

What should this look like in nexus?

  • my file.txt
  • my%20file.txt

Similarly, what should this look like in S3? My current understanding is that only url-encoded strings are allowed, so our options are:

  • my%20file.txt
  • urlencode(my%20file.txt)

It seems as if this ticket is saying that the first option is the correct one, but it's not clear. Perhaps as long as we tell the user the correct path of the file, it doesn't actually matter if the name is double encoded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants