Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging HETATM and ATOM entries into one DataFrame #53

Open
rasbt opened this issue May 31, 2018 · 0 comments
Open

Merging HETATM and ATOM entries into one DataFrame #53

rasbt opened this issue May 31, 2018 · 0 comments

Comments

@rasbt
Copy link
Member

rasbt commented May 31, 2018

Following up on the comment by @wojdyr in #52

by the way, having atoms in two separate frames is rather not a good idea.

At first glance it may look like the protein chains are all ATOM, but wwPDB uses different criterium:

only natural amino-acids (and nucleic acids) are marked as ATOM, and the modified ones are > > > marked as HETATM.
So MET is ATOM but MSE is HETATM.

If you keep them both separately such an example:

  ppdb.df['ATOM']['b_factor'].plot(kind='hist')

won't work as expected - it may skip some residues

That's a good point and I haven't thought of that! The reason why I kept these separate is that I am mostly working on cases where HETATMs refer to non-protein residues. The HETATM--MSE issue should definitely be addressed somehow and I would have to think about it more ... Suggestions would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant