Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in examples/breakout #677

Open
ioneliabuzatu opened this issue Mar 26, 2024 · 2 comments
Open

bug in examples/breakout #677

ioneliabuzatu opened this issue Mar 26, 2024 · 2 comments

Comments

@ioneliabuzatu
Copy link

ioneliabuzatu commented Mar 26, 2024

bug in https://github.com/BindsNET/bindsnet/blob/master/bindsnet/environment/environment.py#L92.

gym.make("env_name") instaed of gym.make(env_id="env_name"). at some point they changed the arg "env_id" to just "id"

original error when running random_baseline.py:

TypeError: make() missing 1 required positional argument: 'id'
@ioneliabuzatu ioneliabuzatu changed the title gym.make needs id bug in examples/breakout Mar 26, 2024
@ioneliabuzatu
Copy link
Author

ioneliabuzatu commented Mar 26, 2024

another bug when running random_network_baseline.py

gymnasium.error.Error: Invalid render mode `None`. Supported modes: `human`, `rgb_array`.

to fix: https://github.com/BindsNET/bindsnet/blob/master/bindsnet/environment/environment.py#L92 change it to
self.env = gym.make(env_id=name, render_mode=render_mode)

@Hananel-Hazan
Copy link
Collaborator

Hananel-Hazan commented Mar 28, 2024

Thank you @ioneliabuzatu

Can you make a PR with those changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants