Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated PC files may cause include shadowing #54

Open
antoniovazquezblanco opened this issue Apr 17, 2023 · 4 comments
Open

Generated PC files may cause include shadowing #54

antoniovazquezblanco opened this issue Apr 17, 2023 · 4 comments

Comments

@antoniovazquezblanco
Copy link
Contributor

For compat reasons, PC files generated by sigutils force to include second level directories via CFLAGS.

It would be best to avoid this but it breaks compilation of suscan and sigdigger. This means that this fix must be timed adecuatedly.

Refs: #53

@antoniovazquezblanco
Copy link
Contributor Author

Having a deeper look at the issue, the current includes structure is:

include
    └───sigutils
        └───sigutils
            ├───specific
            └───util

A possible fix may be to reestructure to:

include
    └───sigutils
        ├───specific
        └───util

and simultaneously remove the conflicting include parameter.

To be studied...

@antoniovazquezblanco
Copy link
Contributor Author

Partial fix in #55

Following steps require fixes in Suscan and Sigdigger. If includes are fixed in this dependent programs, the ofending PC lines can be removed afterwards.

@antoniovazquezblanco
Copy link
Contributor Author

Improved include practices in:

BatchDrake/suscan#67
BatchDrake/SigDigger#206
BatchDrake/SuWidgets#20

This is another partial fix to the issue. After all the mentioned issues are tested and merged, finally, the ofending PC lines can be removed.

@antoniovazquezblanco
Copy link
Contributor Author

All ofending imports have been fixed. Theoretically, level directory inclusion CFLAGS can be removed at the moment.

In order to prevent possible compilation errors with older versions of SigDigger and Suscan with newer Sigutil versions, it may be interesting to postpone this issue fix for a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant