Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that Cholesky only uses the lower triangular part #188

Open
vks opened this issue Jun 2, 2017 · 1 comment
Open

Document that Cholesky only uses the lower triangular part #188

vks opened this issue Jun 2, 2017 · 1 comment

Comments

@vks
Copy link

vks commented Jun 2, 2017

This informs the user that it is possible to only initialize the lower triangular part, saving a few operations.

@Andlon
Copy link
Collaborator

Andlon commented Jun 3, 2017

Yes, this makes sense - on the other hand, if we provide that guarantee we cannot easily change our minds later, because changing this behavior would subtly break user's code without warning (since there are no API breakages or similar).

I am planning to rewrite the Cholesky decomposition to use BLAS-3 in the future, and I can't say for sure if we'd still only access the lower triangular part then - but I think so. I suggest we keep this issue open and revisit when we are more confident in providing such a guarantee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants