Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Matrix::from_fn row-major #172

Open
AtheMathmo opened this issue Apr 28, 2017 · 0 comments
Open

Make Matrix::from_fn row-major #172

AtheMathmo opened this issue Apr 28, 2017 · 0 comments
Labels
easy
Milestone
0.5

Comments

@AtheMathmo
Copy link
Owner

AtheMathmo commented Apr 28, 2017 •
edited

The current function produces a matrix A_ij = f(j,i). This is inconsistent with the rest of the library.

We should instead have the function construct A_ij = f(i,j).

See #157
@AtheMathmo AtheMathmo added this to the 0.5 milestone Apr 28, 2017
MarkDDR added a commit to MarkDDR/rulinalg that referenced this issue May 5, 2017
@MarkDDR
Made Matrix::from_fn row major, fixes (AtheMathmo#172)
0519800 
* Added a test to make sure it is row major as well
@Andlon Andlon mentioned this issue May 5, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@AtheMathmo