Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How are the methods implemented outside of the domain they are designed for? #101

Open
jasperhyp opened this issue Jun 24, 2022 · 1 comment

Comments

@jasperhyp
Copy link

jasperhyp commented Jun 24, 2022

For example, DeepSynergy and MatchMaker are requiring cell line information, and they are both implemented in the DrugBankDDI & TWOSIDES benchmarks where no cell line information is available at all (and TWOSIDES is even at the patient level), with DS reaching the highest performance among all methods. What then was the "cell line gene expression" component in both methods replaced within those tasks? Also, does this ensure a fair comparison?

@jasperhyp
Copy link
Author

jasperhyp commented Jun 26, 2022

I also noticed that all drug features are set to be Morgan FP by design. However, a lot of those models rely on specific features, e.g. SSI-DDI, CASTER both explicitly leverage substructure features. I am not so sure why features are all unified anyways...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant