Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmg for mac on the RC3 #1286

Open
Iragne opened this issue Jun 23, 2023 · 26 comments
Open

Dmg for mac on the RC3 #1286

Iragne opened this issue Jun 23, 2023 · 26 comments

Comments

@Iragne
Copy link
Contributor

Iragne commented Jun 23, 2023

Hi all,

I'm currently using it for my personal project, i also update it to the rc3 by compiling the code and corrected the outdated framework. but it would be great to have an asset as part of the release of the rc3. is that possible ?

here the PR for mac
#1284

@Arne-W
Copy link
Contributor

Arne-W commented Jun 26, 2023

Yes sure, it would be very cool to have someone who can create a Dmg for Mac. Are you interested in building this release only or would you like top participate in future builds too?
I would like to fix the #1285 issue and the problems with the version file and then release the official 2.0.30. I hope I will fix those issues in the next 4 weeks. If you could provide an universal binary for Mac then I will inform you when I push the new Tag!

@billbonney
Copy link
Member

I would suggest you drop building dmg and just create the APMPlanner2.app and then zip it. The dmg was only required when we were shipping the drivers that are no longer required.

This then just simplifies the build process

@Iragne
Copy link
Contributor Author

Iragne commented Jul 7, 2023

Hello all, I would be really interested to help the project and the community. Happy to help in creating build for you and review some.

@Iragne
Copy link
Contributor Author

Iragne commented Jul 13, 2023

@Iragne
Copy link
Contributor Author

Iragne commented Jul 13, 2023

Additionally i created a script for everybody to be able to do the DMG as soon as you can build on Mac
master...Iragne:apm_planner:mac-dmg

@skaman82
Copy link

skaman82 commented Jul 24, 2023

Unfortunately didn't worked for me. I could open the .dmg file and copy the app into applications folder. But every time I try to launch the apmplanner2 - I get an error saying the app is damaged. MacBook Pro (M1 Pro) and Mac OS Ventura
Bildschirmfoto 2023-07-24 um 22 26 19

@Arne-W
Copy link
Contributor

Arne-W commented Jul 28, 2023

@Iragne I created a new tag 2.0.30 it would be extremely cool if you could build a MAC release.

@Iragne
Copy link
Contributor Author

Iragne commented Aug 14, 2023

@Arne-W
Copy link
Contributor

Arne-W commented Aug 25, 2023

@Iragne Do you still want to build a MAC release for us? I am asking because I already tagged the repo and build an appimage for linux and therefore I would highly appreciate a Mac build from you as we could put them to the download server at the same time.

@Iragne
Copy link
Contributor Author

Iragne commented Aug 25, 2023

Hello @Arne-W , i already build it but I was waiting some addtionnal validation in that chat sorry if we get it wrong
if you want to validate the build it's that link that I updated 2 weeks ago
https://github.com/Iragne/apm_planner/releases/download/release-test/apmplanner2.dmg

@Iragne
Copy link
Contributor Author

Iragne commented Aug 25, 2023

I'm building now the tag you mention

@Iragne
Copy link
Contributor Author

Iragne commented Aug 25, 2023

@Arne-W
Copy link
Contributor

Arne-W commented Aug 25, 2023

@Iragne WOW - That was quick 👍 but I can't start the application contained within the dmg. Is it a universal binary or just an ARM image? I am not a Mac user just borrowed the mac of my Girlfriend for testing 😄

@Iragne
Copy link
Contributor Author

Iragne commented Aug 25, 2023

Let me try to find the other m1 i have to check. maybe the fact that i'm building it on my mac is the issue.

@Arne-W
Copy link
Contributor

Arne-W commented Aug 25, 2023

@Iragne Ok I now have access to 2 mac minis - one is a m1 and one is a x86. I tried to open the dmg on the m1 and this is the result:

Screenshot 2023-08-25 at 17 29 34

Do you have any Idea?

@Arne-W
Copy link
Contributor

Arne-W commented Aug 25, 2023

On the x86 Mac it looks like this:
Screenshot 2023-08-25 at 18 00 30

Could it be possible that it is no universal binary and that the Qt framework is not embedded into the dmg package??

@Iragne
Copy link
Contributor Author

Iragne commented Aug 28, 2023

ok i finally make it work on an other mac. sorry but i had only one working
Here the link, I will also create the tutorial because the Qt signin is a bit complex
https://github.com/Iragne/apm_planner/releases/download/release-test/apmplanner2-2.0.30.app.zip
@Arne-W

Today the build is arm64 so i can imagine so compatibility issue on x86.
I'm still working on the DMG not sure i will close by today but i will try https://github.com/Iragne/apm_planner/releases/download/release-test/apmplanner2-2.0.30.dmg

@billbonney
Copy link
Member

There's no need for the dmg. Since you have the app bundled. Delivery of it zipped is the most convenient form.

@Iragne
Copy link
Contributor Author

Iragne commented Aug 29, 2023

So it's here in my previous comment, now should be ARM + x86 @Arne-W
https://github.com/Iragne/apm_planner/releases/download/release-test/apmplanner2-2.0.30.app.zip
https://github.com/Iragne/apm_planner/releases/download/release-test/apmplanner2-2.0.30.dmg

@Iragne
Copy link
Contributor Author

Iragne commented Aug 29, 2023

here the PR that is ongoing #1297

@Arne-W
Copy link
Contributor

Arne-W commented Aug 29, 2023

@Iragne Very cool - thanks for your effort. I hope I will have some time tomorrow to test your builds!!

@Arne-W
Copy link
Contributor

Arne-W commented Aug 30, 2023

@Iragne Alright I tested your builds and they both work on the M1 Mac using Ventura without any issues. Did you sign the builds? Cause the mac did not complain about using unsigned software.
But sadly on the old X86 mac it says "the application is not supported on this mac". It uses Monterey 12.6.8 so it looks like your build still lacks support for X86.

@Iragne
Copy link
Contributor Author

Iragne commented Aug 30, 2023

Hi @Arne-W , yes i signed with a dev build licence but i would expect the mac to ask to allow your to run the app.
Regarding the x86 i'm wondering why, I will have to chase of this mac and understand why the build is not x68 compatible ....

@Arne-W
Copy link
Contributor

Arne-W commented Aug 30, 2023

@Iragne Take a look at your PR I had an Idea to fix the Universal binary issue - and very cool that you signed it!

@Arne-W
Copy link
Contributor

Arne-W commented Aug 30, 2023

@Iragne Your build has no commit ID - do you have an idea why?
missingCommit

@Iragne
Copy link
Contributor Author

Iragne commented Aug 31, 2023

Hum let me check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants