Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots are broken for Mayo entry #3298

Open
HuguesDelorme opened this issue Jan 22, 2024 · 3 comments
Open

Screenshots are broken for Mayo entry #3298

HuguesDelorme opened this issue Jan 22, 2024 · 3 comments

Comments

@HuguesDelorme
Copy link
Contributor

Hello, the screenshots for the Mayo application are not visible and appear broken at https://appimage.github.io/Mayo/
image

appdir-lint.sh did not report errors but just warnings:

WARNING: Icon is not in PNG format. It should be so that it can be used as a thumbnail
Validation was successful.
WARNING: Blacklisted file libX11-xcb.so.1 found
Lint found no fatal issues

What could be the cause of the problem?

@HuguesDelorme
Copy link
Contributor Author

HuguesDelorme commented Jan 25, 2024

Seems like the screenshot links provided by the metadata file are not correct actually, eg:
https://github.com/fougue/mayo/blob/develop/doc/screenshot_ubuntu_main.png
But it's not a direct(raw) link to the file, entering this URL in the browser will display the image within GitHub Files viewer

This is possible with jsDelivr:
https://cdn.jsdelivr.net/gh/fougue/mayo/doc/screenshot_ubuntu_main.png
Or:
https://raw.githubusercontent.com/fougue/mayo/develop/doc/screenshot_ubuntu_main.png

@HuguesDelorme
Copy link
Contributor Author

HuguesDelorme commented Jan 25, 2024

I will fix the screenshots paths in the AppImage metadata file.
There are several screenshots:
image

But by looking at the HTML source, it seems that only the "default" one is displayed in appimage.github.io Mayo entry:
image
Is it possible to make appimage.github.io display all the provided screenshots as a "gallery"?

@probonopd
Copy link
Member

Hello @HuguesDelorme

What could be the cause of the problem?

The link goes to https://github.com/fougue/mayo/blob/develop/doc/screenshot_ubuntu_main.png whereas it would need to go to https://raw.githubusercontent.com/fougue/mayo/develop/doc/screenshot_ubuntu_main.png

Is it possible to make appimage.github.io display all the provided screenshots as a "gallery"?

Right now only one screenshot is being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants