Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between official and community AppImages #3052

Open
mgord9518 opened this issue Nov 3, 2022 · 14 comments · May be fixed by #3053
Open

Differentiate between official and community AppImages #3052

mgord9518 opened this issue Nov 3, 2022 · 14 comments · May be fixed by #3053

Comments

@mgord9518
Copy link

There should be a tag in the database (feed.json) that explicitly tags an AppImage as official -- straight from the developer and manually verified either through obvious means (hosted on the official website) or a public announcement from the developer. This would make it a lot easier to decide on whether to trust a certain software or not.

I understand that this database prefers official AppImages, but it contains many (primarily historical) community made AppImages and there's no good way to set them apart

@probonopd
Copy link
Member

Agree! 👍

Volunteers?

@mgord9518
Copy link
Author

@probonopd I'd be willing but I currently have no clue how to implement it here. Would you have a starting point that I could look at?

@probonopd
Copy link
Member

Well, first of all we would need to work out some logic how to detect whether an AppImage that is being tested has been made by the application's original authors or not. Is this even possible in an automated way?

@probonopd
Copy link
Member

probonopd commented Nov 5, 2022

Another option would be to split up data/ into official/ and inofficial/ by hand, and based on where the file is located, have worker.sh set a key in the .md files that gets written in apps/, like so:

layout: app

type: inofficial

permalink: /86Box/

icons:
  - 86Box/icons/512x512/86box.png

(...)

Once the key is in that file, it'd be trivially easy to make use of that information when rendering the output for the website and the feed.

@mgord9518
Copy link
Author

@probonopd I don't think it would be possible to automate in a reliable fashion.

The splitting of /data is a good idea

By default, all current AppImages (besides the very well-known and obvious ones) would be assumed to be unofficial until manually verified, all new additions would just be verified on submission.

@probonopd
Copy link
Member

Makes sense to me.

@mgord9518
Copy link
Author

@probonopd I've been working on it in a test repo and can't seem to get the database to update. Either Actions says it failed on #set -e or that worker.sh can't find the release page for the AppImage even though it obviously exists. I made pretty minimal modifications to the repo (search for changed files in data/* instead of data and updated worker.sh to add a key if the AppImage is under data/official) any ideas as to why this may be happening?

@mgord9518
Copy link
Author

mgord9518 commented Nov 8, 2022

Nvm, it apparently works with Yuzu, which has a direct link to the AppImage, but not with AppImageUpdate, which links to the GH page. I'll see if I can fix it and clean it up a little, then push it here. There'll be a couple extra commits from testing but nothing too much to read through

EDIT: After some tinkering in my terminal, I believe it's an access token thing. In this line it uses an access token variable, but doesn't appear to be necessary in order to use the API (I know there's a limit, but it's pretty high -- around 1000/hr). The code works perfectly when the access token variable is empty or if the question mark and beyond in the URL is removed. Is it really necessary?

@probonopd
Copy link
Member

You might run into rate limits earlier without a token:

mgord9518@0e9aa20

@mgord9518
Copy link
Author

@probonopd what about having it try with the key and if it fails then gets the info without using it?

Otherwise I don't think there'll be any way I could test it before submitting

@probonopd
Copy link
Member

Could be done that way, yes.

@mgord9518 mgord9518 linked a pull request Nov 9, 2022 that will close this issue
@mgord9518
Copy link
Author

@probonopd Sent in a PR, it looks like a lot of commits but most of them are just deleting/making/renaming files so it should be pretty fast to read through

@Drsheppard01
Copy link
Contributor

I'll help with that. @mgord9518 Is the work in the repository up to date?

@mgord9518
Copy link
Author

@Drsheppard01 Not currently, I'd be happy to update it though

@probonopd probonopd pinned this issue Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants