Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Almost 30% of the entries are useless #2909

Open
zocker-160 opened this issue May 24, 2022 · 13 comments
Open

Almost 30% of the entries are useless #2909

zocker-160 opened this issue May 24, 2022 · 13 comments

Comments

@zocker-160
Copy link

I created a python script which uses the information available and checks the provided urls and I found out that almost 30% of the packages

  • do not have any download url (around 256 packages)
  • download url returns 404 (around 31)
  • does not offer an AppImage in the releases because they stopped offering one (around 129)

here the script (rename from txt to py, GitHub does not accept .py files):

Appchecker.txt

and here my results including the list of applications in each category:

results.txt

I think it would be good to clean this up a bit, because otherwise this repository will become more and more useless and frustrating for users.

@probonopd
Copy link
Member

Thanks for checking @zocker-160. Would you be willing to help keep this directory recent?
But we should not just remove entries, instead we should follow up with the projects to see why things broke. Unless the projects themselves are gone, of course.

@zocker-160
Copy link
Author

zocker-160 commented May 24, 2022

I created this script, because I came across multiple useless entries when searching for AppImages and instead of complaining I though it would make sense to find out which ones are broken and why.

I am not quite sure how I could be helpful with this, I think it would make sense to run this script as a GitHub action and then clean it up bit by bit.
Considering that it is almost one third of the packages, it will be a good amount of work.

I release the script under public domain, so feel free to use it as you see fit.

EDIT: one additional note, the GitHub rate limiter is quite a problem, so the script takes good 15 - 20 minutes to complete

@probonopd
Copy link
Member

probonopd commented May 25, 2022

Quickly looked at your list. Plenty of applictions that you list under "Following items have no URL at all" actually are still alive and well, and are publishing AppImages. So I think you are expecting that all entries in this directory have a direct download link. Thant is not how it works, however. We can, for technical reasons, only show direct download links if

  • The AppImage is hosted on a known infrastructure like GitHub that we have specific support for; and/or
  • The AppImage ships, inside its AppStream data, a link to its download page
    In other cases, we simply don't know where to link to.
    So it could be that many of the "Following items have no URL at all" are false alarms.

In the " Following items' URL returns error code" category, we need to see what happened to them. Especially if 404 is returned, it can mean the project no longer exists, the project has moved to another location, or the project doesn't currently publish AppImages. Here one needs to check fo each project which of those is the case.

For the "Following items' release page does not contain an AppImage file in the latest release", this could mean the project has moved the AppImage to a different location or is simply not offering an AppImage for the latest release (but for at least one earlier one). Here one needs to follow up with the project, see whether the AppImage is at a new location, or ask the project to provide an AppImage for the latest release.

TODO list growing larger and larger. Volunteers?

@zocker-160
Copy link
Author

zocker-160 commented May 25, 2022

Yes I am expecting an url, because entries like this

https://appimage.github.io/Bridge/

are useless.

@probonopd
Copy link
Member

probonopd commented May 25, 2022

In this particular case, there is an AppStream metainfo file missing in the AppImage that would contain the URL to the correct page, https://quixel.com/bridge. The AppImage is available for download there. One would need to work with the authors to get them to incclude an an AppStream metainfo file int he AppImage, and then run the new AppImage through the automated test again.

@zocker-160
Copy link
Author

ah ok understood.

The do not have any download url category is mostly this issue though, where it has no url specified. So my assumption that those projects do not offer an AppImage is wrong, but I think my point still stands, that those entries are not very useful, since I would expect a download link to be available.

@probonopd
Copy link
Member

Agree. We just need volunteers to improve this.

@Drsheppard01
Copy link
Contributor

I will try to fix all non-existent/incorrect data as well as add new applications in the coming days

@prateekmedia
Copy link
Contributor

@probonopd Also none of the KDE apps have download link although I don't know if they contain an AppStream url or not.

@Drsheppard01
Copy link
Contributor

@probonopd Also none of the KDE apps have download link although I don't know if they contain an AppStream url or not.

I'm fixing it now, some kde (peruse) applications are not available at all, some are built via jenkins

@probonopd
Copy link
Member

probonopd commented Aug 7, 2022

I'm fixing it now

We are not manually maintaining this kind of information in this repository, so it needs to be fixed in the upstream AppImages, from which the automated test needs to be able to extract the respective AppStream information.

Please ask if it is not clear what I mean by this. In any case, please do not manually edit any xml or md files in this repository. Thanks!

@Drsheppard01
Copy link
Contributor

Drsheppard01 commented Aug 7, 2022

Please ask if it is not clear what I mean by this. In any case, please do not manually edit any xml or md files in this repository. Thanks!

I forked and amend the links in markdown. If the site is launched, will it break it?

@probonopd
Copy link
Member

The markdown is automatically generated by the test script each time the test runs. So manual changes would be overwritten immediately. The things need to be fixed inside the AppImages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants