Microsoft.Extensions.Http.Polly support for v8 #1657
-
|
Congrats on the v8 release! 😎 Do you have any visibility into when Thanks! |
Beta Was this translation helpful? Give feedback.
Replies: 5 comments 9 replies
-
|
As far as I'm aware, Microsoft have no plans to update Microsoft.Extensions.Http.Polly to natively use the new v8 APIs as the new libraries being released as part of .NET 8 from the dotnet/extensions repository (such as Microsoft.Extensions.Resilience and Microsoft.Extensions.Http.Resilience) will build upon our new API surface and supersede the previous extension which comes from the dotnet/aspnetcore repository. |
Beta Was this translation helpful? Give feedback.
-
|
Got it. Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
See this article that was literally just released 1o days ago: https://learn.microsoft.com/dotnet/core/resilience. I believe you'll have until .NET 9 to migrate over as not everything is in place yet to make that easy/possible. |
Beta Was this translation helpful? Give feedback.
-
|
I'm planning on testing |
Beta Was this translation helpful? Give feedback.
-
|
I'm getting really confused by all of these changes. I just want to add a registry to the service collection, and then associate a pipeline in the registry with an HTTP client.
I'm also not sure how to do the equivalent of |
Beta Was this translation helpful? Give feedback.
-
|
For your first point, this sounds like a feature request where instead of you asking for one to be added you want to make it yourself. Please open a new issue with information about your use case. For the second point, that functionality sounds like something that would be part of dotnet/extensions and the Microsoft.Extensions.Http.Resilience library. If my understanding is correct, please file an issue there for the .NET team to look at. |
Beta Was this translation helpful? Give feedback.
-
I didn't realize that calling
I've opened dotnet/extensions#4666. Thanks for your help. |
Beta Was this translation helpful? Give feedback.
-
|
I tried to migrate the existing MS extension to make it work with Polly v8. You can find nuget here. It was easy to migrate and looks like every scenario is working as expected. I understand all these changes are breaking, apart from that just wondering if I missed something for which MS reimplementing from scratch and had a quick look seems quite complex than the previous implementation. |
Beta Was this translation helpful? Give feedback.
-
|
The re-engineering of Polly was driven primarily to improve performance and reduce allocations, which the previous API didn't lend itself to due iterating on due to the fundamentals of how it was originally designed. We did consider a compatibility layer to redirect the old APIs into the new Polly.Core API, but when we investigated it just made the old API slower due to the overhead of having to bridge between the two quite different API surfaces. |
Beta Was this translation helpful? Give feedback.
-
|
@martincostello after you pointed out the motivation of new Microsoft's extension, I have started looking into it. Seems like we don't have much documentation yet( I may miss as well :-)), so I have started it which is specific to httpclient factory. If you find some time, have a look here - https://anktsrkr.github.io/post/implementing-retry-strategy-using-httpclientfactory-with-pollyv8-and-.net-8/ and let me know if you have any inputs. Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
@IEvangelist Could you point us to the documentation you've been working on for the new resilience libraries? |
Beta Was this translation helpful? Give feedback.
-
|
Yes sir: |
Beta Was this translation helpful? Give feedback.
-
|
The blog post introducing the new library is now also published: https://devblogs.microsoft.com/dotnet/building-resilient-cloud-services-with-dotnet-8/ |
Beta Was this translation helpful? Give feedback.
-
|
Great blog post, Martin! Thank you for sharing :)
…On Wed, Nov 29, 2023, 2:26 AM martintmk ***@***.***> wrote:
The blog post introducing the new library is now also published:
https://devblogs.microsoft.com/dotnet/building-resilient-cloud-services-with-dotnet-8/
—
Reply to this email directly, view it on GitHub
<#1657 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNMWYD2LMT6KOPNCZZZNSDYG3PSNAVCNFSM6AAAAAA5LCIKQSVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM3TOMBRGAZDQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
As far as I'm aware, Microsoft have no plans to update Microsoft.Extensions.Http.Polly to natively use the new v8 APIs as the new libraries being released as part of .NET 8 from the dotnet/extensions repository (such as Microsoft.Extensions.Resilience and Microsoft.Extensions.Http.Resilience) will build upon our new API surface and supersede the previous extension which comes from the dotnet/aspnetcore repository.