-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Use combined startrails and keogram program #3249
Comments
Also allow a user-defined time range to be used, e.g., 4 pm to 6 pm, or more likely, "daytime" or "nighttime". This could be implemented using A new setting called "Include Images" could be used to specify what to include:
|
Great |
I ve always related the start_hour to be the start of dusk and the end_hour to be the start of dawn in keeping with the nomenclature of the documentation. Also, it might make for a cleaner keogram if we had the option to cut off the upper and lower 20pixs of each strip since this is typically ground lighting or ground images. so a normal image that might be 760pix height would end up being 720 after trimming. |
@ssagerian, Steve, I removed the words "dawn" and "dusk" in the update I made last night. Users set the start of daytime (dawn) and start of nighttime (dusk) via the Wouldn't cropping the top and bottom 20 pixels from each image before it's saved also work? |
ah ok, thanks for the clarification on Angle, works for me. I suggested that the trim feature just for the keograms, are you saying trim the actual images in the image folder prior to running the keogram program? |
@ssagerian, Steve, yes, that's what I was asking about. The "CROP" settings in config.sh could be used to get rid of the unwanted parts before the image is saved in the allsky/images folder, but it would impact startrails, timelapse, and of course the current image. |
right, I was only proposing this feature for the keogram, not wanting to impact other images. I archive my daily images after a couple of days and hope to use them for future projects so cropping some of the raw data (as in image-XXXXXXX.jpg files) would make those projects complicated. Adding the feature gives someone the flexibility to do so if they actually notice the issue and feel its a problem. For others, they may never even notice. If I am alone in this opinion, then its ok to drop it from the issue list. I rewrote the keogram.cpp program, convert it to python and can make it an experimental module for my own use. |
@ckuethe created a draft of a combined startrails and keogram program that would read the images once and produce both a startrails image and a keogram image at the same time, thereby decreasing the overall processing time.
The text was updated successfully, but these errors were encountered: