Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Use combined startrails and keogram program #3249

Open
EricClaeys opened this issue Dec 29, 2023 · 7 comments
Open

[ENHANCEMENT] Use combined startrails and keogram program #3249

EricClaeys opened this issue Dec 29, 2023 · 7 comments
Assignees

Comments

@EricClaeys
Copy link
Collaborator

@ckuethe created a draft of a combined startrails and keogram program that would read the images once and produce both a startrails image and a keogram image at the same time, thereby decreasing the overall processing time.

@EricClaeys EricClaeys self-assigned this Dec 29, 2023
@EricClaeys EricClaeys added this to the v2024.xx.xx milestone Dec 29, 2023
@EricClaeys
Copy link
Collaborator Author

Also allow a user-defined time range to be used, e.g., 4 pm to 6 pm, or more likely, "daytime" or "nighttime".

This could be implemented using --from <start_time> and --to <end_time> options.
If no --to is given, all images after <start_time> until the last image in the directory would be used.
If no --from is given, all images starting at the first one in the directory up to and including <end_time> would be used.

A new setting called "Include Images" could be used to specify what to include:

  • All images
  • Day only
  • Night only
  • Custom times (which would show "from" and "to" fields)

sunwait could be used to get the day/night transition times for "Day only" and "Night only"

@troublestarter
Copy link

Great

@ssagerian
Copy link

ssagerian commented Feb 12, 2024

I ve always related the start_hour to be the start of dusk and the end_hour to be the start of dawn in keeping with the nomenclature of the documentation.

Also, it might make for a cleaner keogram if we had the option to cut off the upper and lower 20pixs of each strip since this is typically ground lighting or ground images. so a normal image that might be 760pix height would end up being 720 after trimming.
maybe --trim or --trim_upper --trim_lower or --trim 20 --tu 20 --tl 10 etc

@EricClaeys
Copy link
Collaborator Author

@ssagerian, Steve, I removed the words "dawn" and "dusk" in the update I made last night. Users set the start of daytime (dawn) and start of nighttime (dusk) via the Angle setting.

Wouldn't cropping the top and bottom 20 pixels from each image before it's saved also work?

@ssagerian
Copy link

ah ok, thanks for the clarification on Angle, works for me.

I suggested that the trim feature just for the keograms, are you saying trim the actual images in the image folder prior to running the keogram program?

@EricClaeys
Copy link
Collaborator Author

@ssagerian, Steve, yes, that's what I was asking about. The "CROP" settings in config.sh could be used to get rid of the unwanted parts before the image is saved in the allsky/images folder, but it would impact startrails, timelapse, and of course the current image.

@ssagerian
Copy link

right, I was only proposing this feature for the keogram, not wanting to impact other images. I archive my daily images after a couple of days and hope to use them for future projects so cropping some of the raw data (as in image-XXXXXXX.jpg files) would make those projects complicated. Adding the feature gives someone the flexibility to do so if they actually notice the issue and feel its a problem. For others, they may never even notice. If I am alone in this opinion, then its ok to drop it from the issue list. I rewrote the keogram.cpp program, convert it to python and can make it an experimental module for my own use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants